fix(network): Verify accepted type of incoming game messages#2708
Open
stephanmeesters wants to merge 5 commits into
Open
fix(network): Verify accepted type of incoming game messages#2708stephanmeesters wants to merge 5 commits into
stephanmeesters wants to merge 5 commits into
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/GameNetwork/NetCommandMsg.h | Adds getGameMessageType() declaration to NetGameCommandMsg; uses #pragma once correctly |
| Core/GameEngine/Source/GameNetwork/NetCommandMsg.cpp | Implements the trivial getGameMessageType() accessor returning m_type; no issues |
| Core/GameEngine/Source/GameNetwork/Network.cpp | Renames isTransferCommand to the static isMessageTypeWithinNetworkRange; adds incoming-message type validation guarded by #if !RETAIL_COMPATIBLE_CRC — the security check is inactive in the default build configuration |
Sequence Diagram
sequenceDiagram
participant Remote as Remote Client
participant CM as ConnectionManager
participant Net as Network::RelayCommandsToCommandList
participant CL as TheCommandList
Remote->>CM: Send NetGameCommandMsg (NETCOMMANDTYPE_GAMECOMMAND)
CM->>Net: getFrameCommandList(frame)
Net->>Net: getGameMessageType()
alt "RETAIL_COMPATIBLE_CRC == 1 (default build)"
Net->>CL: appendMessage(constructGameMessage()) [no type check]
else "RETAIL_COMPATIBLE_CRC == 0"
alt type within MSG_BEGIN..MSG_END_NETWORK_MESSAGES
Net->>CL: appendMessage(constructGameMessage())
else type out of range
Net->>Net: DEBUG_LOG(rejecting game message...)
end
end
Reviews (6): Last reviewed commit: "Rework to check message type before crea..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Caball009
reviewed
May 14, 2026
Caball009
added
Minor
Caball009
approved these changes
May 14, 2026
xezon
changed the title
xezon
changed the title
xezon
added
Fix
xezon
approved these changes
May 15, 2026
xezon
reviewed
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently outgoing
GameMessage's are checked usingNetwork::isTransferCommandbut incoming messages are not checked, which can potentially enable certain cheats. Credits to Caball for pointing this out.